diff options
| author | Zhengchao Shao <shaozhengchao@163.com> | 2025-04-09 11:33:21 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-04-10 20:15:26 -0700 |
| commit | 3b4f78f9ad292ad57e3db483332ce7bc799d0d49 (patch) | |
| tree | 833c6e62a89a7c506b2b0ac7689773a0377a3247 | |
| parent | dd4f33b471da719b5ff539616a0d4af1ca123272 (diff) | |
ipv4: remove unnecessary judgment in ip_route_output_key_hash_rcu
In the ip_route_output_key_cash_rcu function, the input fl4 member saddr is
first checked to be non-zero before entering multicast, broadcast and
arbitrary IP address checks. However, the fact that the IP address is not
0 has already ruled out the possibility of any address, so remove
unnecessary judgment.
Signed-off-by: Zhengchao Shao <shaozhengchao@163.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://patch.msgid.link/20250409033321.108244-1-shaozhengchao@163.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | net/ipv4/route.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 753704f75b2c..22dfc971aab4 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2699,8 +2699,7 @@ struct rtable *ip_route_output_key_hash_rcu(struct net *net, struct flowi4 *fl4, if (fl4->saddr) { if (ipv4_is_multicast(fl4->saddr) || - ipv4_is_lbcast(fl4->saddr) || - ipv4_is_zeronet(fl4->saddr)) { + ipv4_is_lbcast(fl4->saddr)) { rth = ERR_PTR(-EINVAL); goto out; } |