diff options
| author | Filipe Manana <fdmanana@suse.com> | 2025-05-16 17:07:40 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2025-07-21 15:31:05 +0200 |
| commit | 3f757b56f1c4579fe32b810bce1d39f202964412 (patch) | |
| tree | 9c5e7af6d2b2a699a6e07e414700030e086d4f2b | |
| parent | 89be9a83ccf1f88522317ce02f854f30d6115c41 (diff) | |
btrfs: unfold transaction aborts at btrfs_create_new_inode()
Instead of having a common btrfs_abort_transaction() call for when either
btrfs_orphan_add() failed or when btrfs_add_link() failed, move the
btrfs_abort_transaction() to happen immediately after each one of those
calls, so that when analysing a stack trace with a transaction abort we
know which call failed.
Reviewed-by: Boris Burkov <boris@bur.io>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/inode.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index fc66872b4c74..bb938d5c0c9b 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -6610,13 +6610,17 @@ int btrfs_create_new_inode(struct btrfs_trans_handle *trans, if (args->orphan) { ret = btrfs_orphan_add(trans, BTRFS_I(inode)); + if (ret) { + btrfs_abort_transaction(trans, ret); + goto discard; + } } else { ret = btrfs_add_link(trans, BTRFS_I(dir), BTRFS_I(inode), name, 0, BTRFS_I(inode)->dir_index); - } - if (ret) { - btrfs_abort_transaction(trans, ret); - goto discard; + if (ret) { + btrfs_abort_transaction(trans, ret); + goto discard; + } } return 0; |