summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKalle Valo <quic_kvalo@quicinc.com>2024-11-01 17:16:58 +0200
committerJeff Johnson <quic_jjohnson@quicinc.com>2024-11-06 11:36:28 -0800
commit757cc46520091ca103b9a948ddbdfa660a10879d (patch)
treea1fccc4454967bb4b1d67dae69ed473c963ab72e
parent38db1ae301c37b3c9599f4f67cd495b6f3a9010e (diff)
wifi: ath12k: ath12k_mac_vdev_create(): use goto for error handling
In commit 477cabfdb776 ("wifi: ath12k: modify link arvif creation and removal for MLO") I had accidentally left one personal TODO comment about using goto instead of ret. Switch to use goto to be consistent with the error handling in the function. Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> Link: https://patch.msgid.link/20241101151705.165987-2-kvalo@kernel.org Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
-rw-r--r--drivers/net/wireless/ath/ath12k/mac.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index d493ec812055..fa48200f012e 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -7034,8 +7034,7 @@ err_peer_del:
ret = ath12k_wait_for_peer_delete_done(ar, arvif->vdev_id,
arvif->bssid);
if (ret)
- /* KVALO: why not goto err? */
- return ret;
+ goto err_vdev_del;
ar->num_peers--;
}