diff options
| author | Douglas Anderson <dianders@chromium.org> | 2020-07-31 13:30:10 -0700 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2020-07-31 16:20:37 -0700 |
| commit | 9f4db31ea09e3c1e25b60b1d93e549fd38360197 (patch) | |
| tree | c10ab51ef6dcb5fae741aea426782ff2159d6ec9 | |
| parent | 3386af51d3bcebcba3f7becdb1ef2e384abe90cf (diff) | |
dt-bindings: clock: Fix YAML schemas for LPASS clocks on SC7180
The YAML schemas that landed forgot one clock: "bi_tcxo". Presumably
the bindings were developed against the v4 version of the driver and
when the ".name" was removed in v5 of the driver things broke.
While touching this, add the needed includes in each example. I
believe both examples are supposed to be independent of each other.
Let's fix the bindings.
Fixes: 381cc6f97cda ("dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7180")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20200731133006.1.Iee81b115f5be50d6d69500fe1bda11bba6e16143@changeid
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
| -rw-r--r-- | Documentation/devicetree/bindings/clock/qcom,sc7180-lpasscorecc.yaml | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7180-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7180-lpasscorecc.yaml index a838250b33e7..c54172fbf29f 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sc7180-lpasscorecc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sc7180-lpasscorecc.yaml @@ -25,10 +25,12 @@ properties: clocks: items: - description: gcc_lpass_sway clock from GCC + - description: Board XO source clock-names: items: - const: iface + - const: bi_tcxo power-domains: maxItems: 1 @@ -77,24 +79,28 @@ additionalProperties: false examples: - | + #include <dt-bindings/clock/qcom,rpmh.h> #include <dt-bindings/clock/qcom,gcc-sc7180.h> #include <dt-bindings/clock/qcom,lpasscorecc-sc7180.h> clock-controller@63000000 { compatible = "qcom,sc7180-lpasshm"; reg = <0x63000000 0x28>; - clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>; - clock-names = "iface"; + clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>, <&rpmhcc RPMH_CXO_CLK>; + clock-names = "iface", "bi_tcxo"; #clock-cells = <1>; #power-domain-cells = <1>; }; - | + #include <dt-bindings/clock/qcom,rpmh.h> + #include <dt-bindings/clock/qcom,gcc-sc7180.h> + #include <dt-bindings/clock/qcom,lpasscorecc-sc7180.h> clock-controller@62d00000 { compatible = "qcom,sc7180-lpasscorecc"; reg = <0x62d00000 0x50000>, <0x62780000 0x30000>; reg-names = "lpass_core_cc", "lpass_audio_cc"; - clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>; - clock-names = "iface"; + clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>, <&rpmhcc RPMH_CXO_CLK>; + clock-names = "iface", "bi_tcxo"; power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; #clock-cells = <1>; #power-domain-cells = <1>; |