diff options
| author | Chenguang Zhao <zhaochenguang@kylinos.cn> | 2024-12-05 10:16:10 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-12-20 16:54:03 +0100 |
| commit | a99e5c8853f4b018b003641ad532059169e271a5 (patch) | |
| tree | 7380e8b3bc4a3ae9d5aed846abbae6266b370f1c | |
| parent | f9e7f3f9620b13d76ed16399b46b29cab1a398f2 (diff) | |
staging: rtl8723bs: Cleanups for rtw_inc_and_chk_continual_io_error
There's a warning when using checkpatch.pl check rtw_io.c:
WARNING: Missing a blank line after declarations
146: FILE: drivers/staging/rtl8723bs/core/rtw_io.c:146:
int value = atomic_inc_return(&dvobj->continual_io_error);
if (value > MAX_CONTINUAL_IO_ERR)
The patch fixes it.
In addition, also rename 'value' variable to 'error_count' and drop
'ret' variable.
Signed-off-by: Chenguang Zhao <zhaochenguang@kylinos.cn>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20241205021610.523528-1-zhaochenguang@kylinos.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/rtl8723bs/core/rtw_io.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c b/drivers/staging/rtl8723bs/core/rtw_io.c index fcda9db6ebb5..79d543d88278 100644 --- a/drivers/staging/rtl8723bs/core/rtw_io.c +++ b/drivers/staging/rtl8723bs/core/rtw_io.c @@ -141,12 +141,12 @@ int rtw_init_io_priv(struct adapter *padapter, void (*set_intf_ops)(struct adapt */ int rtw_inc_and_chk_continual_io_error(struct dvobj_priv *dvobj) { - int ret = false; - int value = atomic_inc_return(&dvobj->continual_io_error); - if (value > MAX_CONTINUAL_IO_ERR) - ret = true; + int error_count = atomic_inc_return(&dvobj->continual_io_error); - return ret; + if (error_count > MAX_CONTINUAL_IO_ERR) + return true; + + return false; } /* |