diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-11-29 17:51:05 +0300 |
|---|---|---|
| committer | Bjorn Andersson <andersson@kernel.org> | 2025-11-29 14:18:23 -0600 |
| commit | cb200e41ed61c571f9b7fe9fbeb5dd8976e80c60 (patch) | |
| tree | 4f3158e9eb0b6657f78718b73078f11fe3e1b7e8 | |
| parent | e7839f773eef2072144fc858b4456aa346fcd665 (diff) | |
remoteproc: qcom: q6v5: Fix NULL vs IS_ERR() bug in q6v5_alloc_memory_region()
The devm_ioremap_resource_wc() function never returns NULL, it returns
error pointers. Update the checking to match.
Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functions for "memory-region"")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/674b32a78563282adeaf3cdf941314a0b8181026.1764427595.git.dan.carpenter@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
| -rw-r--r-- | drivers/remoteproc/qcom_q6v5_wcss.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c index ca748e3bcc7f..d96af0e0f665 100644 --- a/drivers/remoteproc/qcom_q6v5_wcss.c +++ b/drivers/remoteproc/qcom_q6v5_wcss.c @@ -887,9 +887,9 @@ static int q6v5_alloc_memory_region(struct q6v5_wcss *wcss) wcss->mem_reloc = res.start; wcss->mem_size = resource_size(&res); wcss->mem_region = devm_ioremap_resource_wc(dev, &res); - if (!wcss->mem_region) { + if (IS_ERR(wcss->mem_region)) { dev_err(dev, "unable to map memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(wcss->mem_region); } return 0; |