diff options
author | Christian Brauner <brauner@kernel.org> | 2024-08-28 13:08:18 +0200 |
---|---|---|
committer | Christian Brauner <brauner@kernel.org> | 2024-08-29 15:20:33 +0200 |
commit | dfdc8d2565e82d726ce7d99c424c213ed17320f5 (patch) | |
tree | 303fc2b39b85f01582497fcb2f8a2c38bb24063b /include/linux/slab.h | |
parent | c0390d541128e8820af8177a572d9d87ff68a3bb (diff) | |
parent | ea566e18b4deea6e998088de4f1a76d1f39c8d3f (diff) |
Merge patch series "fs,mm: add kmem_cache_create_rcu()"
Christian Brauner <brauner@kernel.org> says:
When a kmem cache is created with SLAB_TYPESAFE_BY_RCU the free pointer
must be located outside of the object because we don't know what part of
the memory can safely be overwritten as it may be needed to prevent
object recycling.
That has the consequence that SLAB_TYPESAFE_BY_RCU may end up adding a
new cacheline. This is the case for e.g., struct file. After having it
shrunk down by 40 bytes and having it fit in three cachelines we still
have SLAB_TYPESAFE_BY_RCU adding a fourth cacheline because it needs to
accommodate the free pointer.
Add a new kmem_cache_create_rcu() function that allows the caller to
specify an offset where the free pointer is supposed to be placed.
Before this series cat /proc/slabinfo:
filp 1198 1248 256 32 2 : tunables 0 0 0 : slabdata 39 39 0
^^^
After this series cat /proc/slabinfo:
filp 1323 1323 192 21 1 : tunables 0 0 0 : slabdata 63 63 0
^^^
* patches from https://lore.kernel.org/r/20240828-work-kmem_cache-rcu-v3-0-5460bc1f09f6@kernel.org:
fs: use kmem_cache_create_rcu()
mm: add kmem_cache_create_rcu()
mm: remove unused root_cache argument
Link: https://lore.kernel.org/r/20240828-work-kmem_cache-rcu-v3-0-5460bc1f09f6@kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'include/linux/slab.h')
-rw-r--r-- | include/linux/slab.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/include/linux/slab.h b/include/linux/slab.h index eb2bf4629157..5b2da2cf31a8 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -213,6 +213,12 @@ enum _slab_flag_bits { #endif /* + * freeptr_t represents a SLUB freelist pointer, which might be encoded + * and not dereferenceable if CONFIG_SLAB_FREELIST_HARDENED is enabled. + */ +typedef struct { unsigned long v; } freeptr_t; + +/* * ZERO_SIZE_PTR will be returned for zero sized kmalloc requests. * * Dereferencing ZERO_SIZE_PTR will lead to a distinct access fault. @@ -242,6 +248,9 @@ struct kmem_cache *kmem_cache_create_usercopy(const char *name, slab_flags_t flags, unsigned int useroffset, unsigned int usersize, void (*ctor)(void *)); +struct kmem_cache *kmem_cache_create_rcu(const char *name, unsigned int size, + unsigned int freeptr_offset, + slab_flags_t flags); void kmem_cache_destroy(struct kmem_cache *s); int kmem_cache_shrink(struct kmem_cache *s); |