summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorYue Haibing <yuehaibing@huawei.com>2025-06-24 09:42:16 +0800
committerJakub Kicinski <kuba@kernel.org>2025-06-25 15:26:03 -0700
commit9b19b50c8d65e06d4ff7f230855a2a28ac200f35 (patch)
treed7231e3473a6d2d594a4ea37a52a52f7ad3d8e9f /net
parentb48d353d24d92dce2ea31aa248e2584980f7c989 (diff)
neighbour: Remove redundant assignment to err
'err' has been checked against 0 in the if statement. Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20250624014216.3686659-1-yuehaibing@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
-rw-r--r--net/core/neighbour.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 85a5535de8ba..8ad9898f8e42 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -2055,10 +2055,8 @@ static int neigh_add(struct sk_buff *skb, struct nlmsghdr *nlh,
err = __neigh_update(neigh, lladdr, ndm->ndm_state, flags,
NETLINK_CB(skb).portid, extack);
- if (!err && ndm_flags & (NTF_USE | NTF_MANAGED)) {
+ if (!err && ndm_flags & (NTF_USE | NTF_MANAGED))
neigh_event_send(neigh, NULL);
- err = 0;
- }
neigh_release(neigh);
out:
return err;