diff options
author | André Almeida <andrealmeid@igalia.com> | 2025-07-04 00:06:29 -0300 |
---|---|---|
committer | André Almeida <andrealmeid@igalia.com> | 2025-07-10 18:41:21 -0300 |
commit | 667efb341917bde19f5d7517b65defcdaed67c9e (patch) | |
tree | 32b90d4dc9a6129807071e06856bb7ede4f61b26 /rust/kernel | |
parent | cf590b239c98ff7772c61a9124dbcb5f250e9395 (diff) |
drm/amdgpu: Fix lifetime of struct amdgpu_task_info after ring reset
When a ring reset happens, amdgpu calls drm_dev_wedged_event() using
struct amdgpu_task_info *ti as one of the arguments. After using *ti, a
call to amdgpu_vm_put_task_info(ti) is required to correctly track its
lifetime.
However, it's called from a place that the ring reset path never reaches
due to a goto after drm_dev_wedged_event() is called. Move
amdgpu_vm_put_task_info() bellow the exit label to make sure that it's
called regardless of the code path.
amdgpu_vm_put_task_info() can only accept a valid address or NULL as
argument, so initialise *ti to make sure we can call this function if
*ti isn't used.
Fixes: a72002cb181f ("drm/amdgpu: Make use of drm_wedge_task_info")
Reported-by: Dave Airlie <airlied@gmail.com>
Closes: https://lore.kernel.org/dri-devel/CAPM=9tz0rQP8VZWKWyuF8kUMqRScxqoa6aVdwWw9=5yYxyYQ2Q@mail.gmail.com/
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://lore.kernel.org/r/20250704030629.1064397-1-andrealmeid@igalia.com
Signed-off-by: André Almeida <andrealmeid@igalia.com>
Diffstat (limited to 'rust/kernel')
0 files changed, 0 insertions, 0 deletions