diff options
| author | Vincent Guittot <vincent.guittot@linaro.org> | 2025-07-08 18:56:28 +0200 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2025-07-09 13:40:23 +0200 |
| commit | 052c3d87c82ea4ee83232b747512847b4e8c9976 (patch) | |
| tree | bbe18c3cac48154b8291026052583c755ebfbc9c | |
| parent | 9de74a9850b9468ac2f515bfbe0844e0bfae869d (diff) | |
sched/fair: Limit run to parity to the min slice of enqueued entities
Run to parity ensures that current will get a chance to run its full
slice in one go but this can create large latency and/or lag for
entities with shorter slice that have exhausted their previous slice
and wait to run their next slice.
Clamp the run to parity to the shortest slice of all enqueued entities.
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20250708165630.1948751-5-vincent.guittot@linaro.org
| -rw-r--r-- | kernel/sched/fair.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 96718b3b4bd1..45e057fc2354 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -884,18 +884,20 @@ struct sched_entity *__pick_first_entity(struct cfs_rq *cfs_rq) /* * Set the vruntime up to which an entity can run before looking * for another entity to pick. - * In case of run to parity, we protect the entity up to its deadline. + * In case of run to parity, we use the shortest slice of the enqueued + * entities to set the protected period. * When run to parity is disabled, we give a minimum quantum to the running * entity to ensure progress. */ static inline void set_protect_slice(struct sched_entity *se) { - u64 slice = se->slice; + u64 slice = normalized_sysctl_sched_base_slice; u64 vprot = se->deadline; - if (!sched_feat(RUN_TO_PARITY)) - slice = min(slice, normalized_sysctl_sched_base_slice); + if (sched_feat(RUN_TO_PARITY)) + slice = cfs_rq_min_slice(cfs_rq_of(se)); + slice = min(slice, se->slice); if (slice != se->slice) vprot = min_vruntime(vprot, se->vruntime + calc_delta_fair(slice, se)); |