summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNai-Chen Cheng <bleach1827@gmail.com>2025-08-06 14:27:11 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-08-19 12:50:31 +0200
commit0e805e8b007d42502dbb7b883cae4794890a40ff (patch)
tree84c489f3c7195c04c1785bbf91eca7da27af7f85
parent51ad6d97151c88976a93cdc023d6cd27dce48c38 (diff)
greybus: svc: use string choice helpers instead of ternary operator
Replace ternary operator with str_enabled_disabled() helper to improve code readability and consistency. Generated using Coccinelle semantic patch. Signed-off-by: Nai-Chen Cheng <bleach1827@gmail.com> Reviewed-by: Alex Elder <elder@riscstar.com> Link: https://lore.kernel.org/r/20250806-greybus-string-choices-v1-1-3e1c91048b62@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/greybus/svc.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/greybus/svc.c b/drivers/greybus/svc.c
index 4256467fcd35..35ea7147dca6 100644
--- a/drivers/greybus/svc.c
+++ b/drivers/greybus/svc.c
@@ -10,6 +10,7 @@
#include <linux/kstrtox.h>
#include <linux/workqueue.h>
#include <linux/greybus.h>
+#include <linux/string_choices.h>
#define SVC_INTF_EJECT_TIMEOUT 9000
#define SVC_INTF_ACTIVATE_TIMEOUT 6000
@@ -73,7 +74,7 @@ static ssize_t watchdog_show(struct device *dev, struct device_attribute *attr,
struct gb_svc *svc = to_gb_svc(dev);
return sprintf(buf, "%s\n",
- gb_svc_watchdog_enabled(svc) ? "enabled" : "disabled");
+ str_enabled_disabled(gb_svc_watchdog_enabled(svc)));
}
static ssize_t watchdog_store(struct device *dev,