diff options
| author | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2025-09-12 07:13:11 +0900 |
|---|---|---|
| committer | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2025-09-12 07:54:23 +0900 |
| commit | 136d8a6f73fee0686d163dca91fdffb35e25f092 (patch) | |
| tree | 578175f88a36092043a11306ebeb9bde1be3a5ea | |
| parent | a4bac55d99d37976209e2fc2c32bd3dfc86b0447 (diff) | |
firewire: core: remove useless lockdep_assert_held()
The bm_work work item should be scheduled after holding fw_card reference
counting. At a commit 25feb1a96e21 ("firewire: core: use cleanup function
in bm_work"), I misinterpreted it as fw_card spinlock and inserted
lockdep_assert_hold() wrongly.
This commit removes the useless line.
Fixes: 25feb1a96e21 ("firewire: core: use cleanup function in bm_work")
Link: https://lore.kernel.org/r/20250911221312.678076-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
| -rw-r--r-- | drivers/firewire/core-card.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/firewire/core-card.c b/drivers/firewire/core-card.c index 474d8066e090..32cf6b3344cd 100644 --- a/drivers/firewire/core-card.c +++ b/drivers/firewire/core-card.c @@ -294,8 +294,6 @@ static void bm_work(struct work_struct *work) int expected_gap_count, generation, grace; bool do_reset = false; - lockdep_assert_held(&card->lock); - spin_lock_irq(&card->lock); if (card->local_node == NULL) { |