diff options
| author | Kurt Borja <kuurtb@gmail.com> | 2025-04-25 12:45:06 -0300 |
|---|---|---|
| committer | Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> | 2025-04-30 14:05:56 +0300 |
| commit | 1fe9596a70d40b017f698db42621ec96da3a0cac (patch) | |
| tree | 9a0b39d60146dcba0f33d270776bbe9f2553b869 | |
| parent | 317bbe169c468b5dbe3ddc27b0a02f8981ede5b4 (diff) | |
platform/x86: alienware-wmi-wmax: Fix uninitialized bitmap in awcc_hwmon_fans_init()
Initialize fan_temps bitmap to zero before using it for the first time
in each iteration.
Fixes: d69990783495 ("platform/x86: alienware-wmi-wmax: Add HWMON support")
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20250425-temp-id-fix-v1-1-372d71f732bf@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
| -rw-r--r-- | drivers/platform/x86/dell/alienware-wmi-wmax.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c b/drivers/platform/x86/dell/alienware-wmi-wmax.c index faeddfe3b79e..27e5b0b23c27 100644 --- a/drivers/platform/x86/dell/alienware-wmi-wmax.c +++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c @@ -1027,6 +1027,8 @@ static int awcc_hwmon_fans_init(struct wmi_device *wdev) if (ret) return ret; + bitmap_zero(fan_temps, AWCC_ID_BITMAP_SIZE); + for (j = 0; j < temp_count; j++) { ret = awcc_get_fan_sensors(wdev, AWCC_OP_GET_FAN_TEMP_ID, id, j, &temp_id); @@ -1048,8 +1050,6 @@ static int awcc_hwmon_fans_init(struct wmi_device *wdev) bitmap_gather(gather, fan_temps, priv->temp_sensors, AWCC_ID_BITMAP_SIZE); bitmap_copy(&fan_data->auto_channels_temp, gather, BITS_PER_LONG); priv->fan_data[i] = fan_data; - - bitmap_zero(fan_temps, AWCC_ID_BITMAP_SIZE); } return 0; |