diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-09-25 16:28:13 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-09-26 15:23:55 -0700 |
| commit | 347afa39042728267550fa7a5ab5e9af52671add (patch) | |
| tree | e29c241c89b781a5b470504ccb8b6418075bf1b9 | |
| parent | 81dcfdd21dbd7067068c7c341ee448c3f0d6f115 (diff) | |
dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update()
The zl3073x_devlink_flash_prepare() function calls zl3073x_fw_free() and
the caller, zl3073x_devlink_flash_update(), also calls that same free
function so it leads to a double free. Delete the extra free.
Fixes: a1e891fe4ae8 ("dpll: zl3073x: Implement devlink flash callback")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/aNVDbcIQq4RmU_fl@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/dpll/zl3073x/devlink.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/dpll/zl3073x/devlink.c b/drivers/dpll/zl3073x/devlink.c index f55d5309d4f9..ccc22332b346 100644 --- a/drivers/dpll/zl3073x/devlink.c +++ b/drivers/dpll/zl3073x/devlink.c @@ -167,7 +167,6 @@ zl3073x_devlink_flash_prepare(struct zl3073x_dev *zldev, zl3073x_devlink_flash_notify(zldev, "Utility is missing in firmware", NULL, 0, 0); - zl3073x_fw_free(zlfw); return -ENOEXEC; } |