diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-07-15 18:01:30 -0500 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-07-17 18:37:48 -0700 |
| commit | 49be1e245ea3e3515c5989ce1af215d8500dec85 (patch) | |
| tree | 71fb8cbb383065951621c829507e676803769bc2 | |
| parent | c2fe3b2a7c71adccff9d7f651004405fa413bf17 (diff) | |
net/mlx5: Fix an IS_ERR() vs NULL bug in esw_qos_move_node()
The __esw_qos_alloc_node() function returns NULL on error. It doesn't
return error pointers. Update the error checking to match.
Fixes: 96619c485fa6 ("net/mlx5: Add support for setting tc-bw on nodes")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/0ce4ec2a-2b5d-4652-9638-e715a99902a7@sabinyo.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c index e1cef8dd3b4d..91d863c8c152 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c @@ -1405,9 +1405,10 @@ esw_qos_move_node(struct mlx5_esw_sched_node *curr_node) new_node = __esw_qos_alloc_node(curr_node->esw, curr_node->ix, curr_node->type, NULL); - if (!IS_ERR(new_node)) - esw_qos_nodes_set_parent(&curr_node->children, new_node); + if (!new_node) + return ERR_PTR(-ENOMEM); + esw_qos_nodes_set_parent(&curr_node->children, new_node); return new_node; } |