summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Hung <alex.hung@amd.com>2025-11-14 17:02:07 -0700
committerSimon Ser <contact@emersion.fr>2025-11-26 23:03:36 +0100
commit68186c7375ace5597383115cd3781ac8465dac99 (patch)
tree0a953eb90cc71ecbc582adcb7e6107773c09fa07
parentde0b0eb2e04500797636a94436ac367d4a40d951 (diff)
drm/amd/display: Swap matrix and multiplier
Swap the order of matrix and multiplier as designed in hardware. Signed-off-by: Alex Hung <alex.hung@amd.com> Reviewed-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Melissa Wen <mwen@igalia.com> Signed-off-by: Simon Ser <contact@emersion.fr> Link: https://patch.msgid.link/20251115000237.3561250-43-alex.hung@amd.com
-rw-r--r--drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c12
-rw-r--r--drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c8
2 files changed, 10 insertions, 10 deletions
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
index e0788be907a7..868f3500cb85 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
@@ -1651,25 +1651,25 @@ amdgpu_dm_plane_set_colorop_properties(struct drm_plane_state *plane_state,
if (ret)
return ret;
- /* 3x4 matrix */
+ /* Multiplier */
colorop = colorop->next;
if (!colorop) {
- drm_dbg(dev, "no 3x4 matrix colorop found\n");
+ drm_dbg(dev, "no multiplier colorop found\n");
return -EINVAL;
}
- ret = __set_dm_plane_colorop_3x4_matrix(plane_state, dc_plane_state, colorop);
+ ret = __set_dm_plane_colorop_multiplier(plane_state, dc_plane_state, colorop);
if (ret)
return ret;
- /* Multiplier */
+ /* 3x4 matrix */
colorop = colorop->next;
if (!colorop) {
- drm_dbg(dev, "no multiplier colorop found\n");
+ drm_dbg(dev, "no 3x4 matrix colorop found\n");
return -EINVAL;
}
- ret = __set_dm_plane_colorop_multiplier(plane_state, dc_plane_state, colorop);
+ ret = __set_dm_plane_colorop_3x4_matrix(plane_state, dc_plane_state, colorop);
if (ret)
return ret;
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c
index 098c98cc64ff..33907cc8e1b3 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c
@@ -74,14 +74,14 @@ int amdgpu_dm_initialize_default_pipeline(struct drm_plane *plane, struct drm_pr
i++;
- /* 3x4 matrix */
+ /* Multiplier */
ops[i] = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
if (!ops[i]) {
ret = -ENOMEM;
goto cleanup;
}
- ret = drm_plane_colorop_ctm_3x4_init(dev, ops[i], plane);
+ ret = drm_plane_colorop_mult_init(dev, ops[i], plane);
if (ret)
goto cleanup;
@@ -89,14 +89,14 @@ int amdgpu_dm_initialize_default_pipeline(struct drm_plane *plane, struct drm_pr
i++;
- /* Multiplier */
+ /* 3x4 matrix */
ops[i] = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
if (!ops[i]) {
ret = -ENOMEM;
goto cleanup;
}
- ret = drm_plane_colorop_mult_init(dev, ops[i], plane);
+ ret = drm_plane_colorop_ctm_3x4_init(dev, ops[i], plane);
if (ret)
goto cleanup;