diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-09-04 21:58:54 +0300 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2025-09-08 14:24:12 +0200 |
| commit | 6c3442b3b692769c9bced80da58e0130b9fa16cc (patch) | |
| tree | fd34618985f6dc9ac8f4711cc608f48432081cb4 | |
| parent | 83d12f08ddfba09db414b611195af23fdeb70836 (diff) | |
pinctrl: keembay: fix double free in keembay_build_functions()
This kfree() was accidentally left over when we converted to devm_
and it would lead to a double free. Delete it.
Fixes: 995bc9f4826e ("pinctrl: keembay: release allocated memory in detach path")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/pinctrl/pinctrl-keembay.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/pinctrl/pinctrl-keembay.c b/drivers/pinctrl/pinctrl-keembay.c index 30122ca90cbe..3241d3ae6219 100644 --- a/drivers/pinctrl/pinctrl-keembay.c +++ b/drivers/pinctrl/pinctrl-keembay.c @@ -1643,10 +1643,8 @@ static int keembay_build_functions(struct keembay_pinctrl *kpc) new_funcs = devm_krealloc_array(kpc->dev, keembay_funcs, kpc->nfuncs, sizeof(*new_funcs), GFP_KERNEL); - if (!new_funcs) { - kfree(keembay_funcs); + if (!new_funcs) return -ENOMEM; - } return keembay_add_functions(kpc, new_funcs); } |