diff options
| author | Ujwal Kundur <ujwal.kundur@gmail.com> | 2025-08-20 23:25:49 +0530 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-08-22 16:44:39 -0700 |
| commit | 77907a068717fbefb25faf01fecca553aca6ccaa (patch) | |
| tree | 2db808cf188c97a172bc70211b21c3112fe2f5d4 | |
| parent | 92b925297a2f233e0b16694df7b524360b8abb93 (diff) | |
rds: Fix endianness annotation for RDS_MPATH_HASH
jhash_1word accepts host endian inputs while rs_bound_port is a be16
value (sockaddr_in6.sin6_port). Use ntohs() for consistency.
Flagged by Sparse.
Signed-off-by: Ujwal Kundur <ujwal.kundur@gmail.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Link: https://patch.msgid.link/20250820175550.498-4-ujwal.kundur@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | net/rds/rds.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rds/rds.h b/net/rds/rds.h index dc360252c515..5b1c072e2e7f 100644 --- a/net/rds/rds.h +++ b/net/rds/rds.h @@ -93,7 +93,7 @@ enum { /* Max number of multipaths per RDS connection. Must be a power of 2 */ #define RDS_MPATH_WORKERS 8 -#define RDS_MPATH_HASH(rs, n) (jhash_1word((rs)->rs_bound_port, \ +#define RDS_MPATH_HASH(rs, n) (jhash_1word(ntohs((rs)->rs_bound_port), \ (rs)->rs_hash_initval) & ((n) - 1)) #define IS_CANONICAL(laddr, faddr) (htonl(laddr) < htonl(faddr)) |