diff options
| author | Vlastimil Babka <vbabka@suse.cz> | 2025-09-03 14:59:44 +0200 |
|---|---|---|
| committer | Vlastimil Babka <vbabka@suse.cz> | 2025-09-26 11:56:36 +0200 |
| commit | 9d4e6ab865c48c70e684b176d3ee1574d092626f (patch) | |
| tree | fe6505e113928316e2bcd9a427fd6a75095a2ae5 | |
| parent | 212b0f07cf021575ec25e0b2336df77c7a4d2e68 (diff) | |
slab: simplify init_kmem_cache_nodes() error handling
We don't need to call free_kmem_cache_nodes() immediately when failing
to allocate a kmem_cache_node, because when we return 0,
do_kmem_cache_create() calls __kmem_cache_release() which also performs
free_kmem_cache_nodes().
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
| -rw-r--r-- | mm/slub.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/mm/slub.c b/mm/slub.c index 30003763d224..9f671ec76131 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5669,10 +5669,8 @@ static int init_kmem_cache_nodes(struct kmem_cache *s) n = kmem_cache_alloc_node(kmem_cache_node, GFP_KERNEL, node); - if (!n) { - free_kmem_cache_nodes(s); + if (!n) return 0; - } init_kmem_cache_node(n); s->node[node] = n; |