diff options
| author | Heiko Stuebner <heiko@sntech.de> | 2025-11-13 17:52:15 +0100 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2025-11-20 10:14:06 +0000 |
| commit | b4881070a02b017aea84592c424d5a980ed261c4 (patch) | |
| tree | 17363bdacbdbaea91798fcd30a3ad91c4a8e4410 | |
| parent | 46bddb5fbe7e3cb73204a952dbd4687cf0974ef5 (diff) | |
mfd: qnap-mcu: Calculate the checksum on the actual number of bytes received
In the case of an error message, the number of received bytes can be
less than originally expected but still contain a valid message.
If the transfer itself ended in an error we would exit earlier already.
So calculate the checksum on the number of received bytes and not the
number of expected bytes.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patch.msgid.link/20251113165218.449616-2-heiko@sntech.de
Signed-off-by: Lee Jones <lee@kernel.org>
| -rw-r--r-- | drivers/mfd/qnap-mcu.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mfd/qnap-mcu.c b/drivers/mfd/qnap-mcu.c index 4ec1f4cf902f..4cd5319fc6cb 100644 --- a/drivers/mfd/qnap-mcu.c +++ b/drivers/mfd/qnap-mcu.c @@ -175,8 +175,8 @@ int qnap_mcu_exec(struct qnap_mcu *mcu, return -ETIMEDOUT; } - crc = qnap_mcu_csum(rx, reply_data_size); - if (crc != rx[reply_data_size]) { + crc = qnap_mcu_csum(rx, reply->received - QNAP_MCU_CHECKSUM_SIZE); + if (crc != rx[reply->received - QNAP_MCU_CHECKSUM_SIZE]) { dev_err(&mcu->serdev->dev, "Invalid Checksum received\n"); return -EIO; } |