diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2025-06-15 01:33:21 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2025-06-16 16:21:07 +0200 |
| commit | b5ba648a7dd2b42725ae2d07335f0551111437a2 (patch) | |
| tree | 5a8b0a54f7d642f6d5e75c2a2accd58522c49195 | |
| parent | 88b1de54979c7ac8b1faec646c600ce66f0da24e (diff) | |
proc_fd_getattr(): don't bother with S_ISDIR() check
that thing is callable only as ->i_op->getattr() instance and only
for directory inodes (/proc/*/fd and /proc/*/task/*/fd)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Link: https://lore.kernel.org/20250615003321.GC3011112@ZenIV
Reviewed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/proc/fd.c | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/fs/proc/fd.c b/fs/proc/fd.c index 37aa778d1af7..9eeccff49b2a 100644 --- a/fs/proc/fd.c +++ b/fs/proc/fd.c @@ -352,18 +352,9 @@ static int proc_fd_getattr(struct mnt_idmap *idmap, u32 request_mask, unsigned int query_flags) { struct inode *inode = d_inode(path->dentry); - int rv = 0; generic_fillattr(&nop_mnt_idmap, request_mask, inode, stat); - - /* If it's a directory, put the number of open fds there */ - if (S_ISDIR(inode->i_mode)) { - rv = proc_readfd_count(inode, &stat->size); - if (rv < 0) - return rv; - } - - return rv; + return proc_readfd_count(inode, &stat->size); } const struct inode_operations proc_fd_inode_operations = { |