diff options
| author | Kuan-Wei Chiu <visitorckw@gmail.com> | 2025-08-26 14:23:15 +0800 |
|---|---|---|
| committer | Vlastimil Babka <vbabka@suse.cz> | 2025-09-10 22:52:33 +0200 |
| commit | ba7a896427cbade13d30f3c7e18c15e8be243c18 (patch) | |
| tree | c6d87e4b45a38d99f39cff2795f2ab87276a105a | |
| parent | e1c4350327b39c9cad27b6c5779b3754384f26c8 (diff) | |
mm/slub: Replace sort_r() with sort() for debugfs stack trace sorting
The comparison function used to sort stack trace locations in debugfs
never relied on the third argument. Therefore, sort_r() is unnecessary.
Switch to sort() with a two-argument comparison function to keep the
code simple and aligned with the intended usage.
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
| -rw-r--r-- | mm/slub.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/mm/slub.c b/mm/slub.c index 264fc76455d7..9074ce914e9e 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -7726,7 +7726,7 @@ static void *slab_debugfs_next(struct seq_file *seq, void *v, loff_t *ppos) return NULL; } -static int cmp_loc_by_count(const void *a, const void *b, const void *data) +static int cmp_loc_by_count(const void *a, const void *b) { struct location *loc1 = (struct location *)a; struct location *loc2 = (struct location *)b; @@ -7793,8 +7793,8 @@ static int slab_debug_trace_open(struct inode *inode, struct file *filep) } /* Sort locations by count */ - sort_r(t->loc, t->count, sizeof(struct location), - cmp_loc_by_count, NULL, NULL); + sort(t->loc, t->count, sizeof(struct location), + cmp_loc_by_count, NULL); bitmap_free(obj_map); return 0; |