diff options
| author | Geert Uytterhoeven <geert+renesas@glider.be> | 2019-08-30 15:45:10 +0200 | 
|---|---|---|
| committer | Geert Uytterhoeven <geert+renesas@glider.be> | 2019-10-01 10:24:49 +0200 | 
| commit | e8adb3a0f74cf568030b7bd1f77d877e6f308d17 (patch) | |
| tree | 4ae9e94ec62c3eefc10263f1953f1156760782c2 | |
| parent | b5dea62d34042d173ba1d1887c8dd40262423d68 (diff) | |
clk: renesas: rcar-gen3: Avoid double table iteration in SD .set_rate()
The .set_rate() callback for the SD clocks is always called with a valid
clock rate, returned by .round_rate().  Hence there is no need to
iterate through the divider table twice: once to repeat the work done by
.round_rate(), and a second time to find the corresponding divider
entry.
Just iterate once, looking for the divider that matches the passed clock
rate.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20190830134515.11925-4-geert+renesas@glider.be
| -rw-r--r-- | drivers/clk/renesas/rcar-gen3-cpg.c | 6 | 
1 files changed, 3 insertions, 3 deletions
| diff --git a/drivers/clk/renesas/rcar-gen3-cpg.c b/drivers/clk/renesas/rcar-gen3-cpg.c index c594bc067c3b..0866be30dc72 100644 --- a/drivers/clk/renesas/rcar-gen3-cpg.c +++ b/drivers/clk/renesas/rcar-gen3-cpg.c @@ -339,14 +339,14 @@ static long cpg_sd_clock_round_rate(struct clk_hw *hw, unsigned long rate,  }  static int cpg_sd_clock_set_rate(struct clk_hw *hw, unsigned long rate, -				   unsigned long parent_rate) +				 unsigned long parent_rate)  {  	struct sd_clock *clock = to_sd_clock(hw); -	unsigned int div = cpg_sd_clock_calc_div(clock, rate, parent_rate);  	unsigned int i;  	for (i = 0; i < clock->div_num; i++) -		if (div == clock->div_table[i].div) +		if (rate == DIV_ROUND_CLOSEST(parent_rate, +					      clock->div_table[i].div))  			break;  	if (i >= clock->div_num) | 
