diff options
| author | Liao Chang <liaochang1@huawei.com> | 2025-01-24 09:38:25 +0000 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2025-02-03 11:46:06 +0100 |
| commit | eae8a56ae0c74c1cf2f92a6709d215a9f329f60c (patch) | |
| tree | fbb8d85795a85247c991a43162e52fb10891e228 | |
| parent | fa5d0a824e3bbd1f793d962f9e012ab0a8ee11c5 (diff) | |
uprobes: Remove redundant spinlock in uprobe_deny_signal()
Since clearing a bit in thread_info is an atomic operation, the spinlock
is redundant and can be removed, reducing lock contention is good for
performance.
Signed-off-by: Liao Chang <liaochang1@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Link: https://lore.kernel.org/r/20250124093826.2123675-2-liaochang1@huawei.com
| -rw-r--r-- | kernel/events/uprobes.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 2ca797cbe465..33bd6083f7c4 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -2302,9 +2302,7 @@ bool uprobe_deny_signal(void) WARN_ON_ONCE(utask->state != UTASK_SSTEP); if (task_sigpending(t)) { - spin_lock_irq(&t->sighand->siglock); clear_tsk_thread_flag(t, TIF_SIGPENDING); - spin_unlock_irq(&t->sighand->siglock); if (__fatal_signal_pending(t) || arch_uprobe_xol_was_trapped(t)) { utask->state = UTASK_SSTEP_TRAPPED; |