diff options
| author | Filipe Manana <fdmanana@suse.com> | 2025-09-01 16:37:05 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2025-09-23 08:49:20 +0200 |
| commit | f366722f3370dd561d45e667484c458245977e79 (patch) | |
| tree | ff1febcc2521f288845c806493a61b419064c8df | |
| parent | b343047c1a08779efb0d2691a8c6391318025cc6 (diff) | |
btrfs: avoid unnecessary path allocation when replaying a dir item
There's no need to allocate 'fixup_path' at replay_one_dir_item(), as the
path passed as an argument is unused by the time link_to_fixup_dir() is
called (replay_one_name() releases the path before it returns).
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/tree-log.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index a912ccdf1485..de1f1c024dc0 100644 --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c @@ -2147,18 +2147,10 @@ static noinline int replay_one_dir_item(struct walk_control *wc, * dentries that can never be deleted. */ if (ret == 1 && btrfs_dir_ftype(wc->log_leaf, di) != BTRFS_FT_DIR) { - struct btrfs_path *fixup_path; struct btrfs_key di_key; - fixup_path = btrfs_alloc_path(); - if (!fixup_path) { - btrfs_abort_transaction(wc->trans, -ENOMEM); - return -ENOMEM; - } - btrfs_dir_item_key_to_cpu(wc->log_leaf, di, &di_key); - ret = link_to_fixup_dir(wc, fixup_path, di_key.objectid); - btrfs_free_path(fixup_path); + ret = link_to_fixup_dir(wc, path, di_key.objectid); } return ret; |