diff options
author | Andrew Price <anprice@redhat.com> | 2025-07-16 14:12:07 +0100 |
---|---|---|
committer | Andreas Gruenbacher <agruenba@redhat.com> | 2025-07-16 15:26:44 +0200 |
commit | 557c024ca7250bb65ae60f16c02074106c2f197b (patch) | |
tree | 222038b5225f47c4d318058a0530efb2b2076525 /lib/crypto/mpi/mpiutil.c | |
parent | 5c8f12cf1e64e0e8e6cb80b0c935389973e8be8d (diff) |
gfs2: Validate i_depth for exhash directories
A fuzzer test introduced corruption that ends up with a depth of 0 in
dir_e_read(), causing an undefined shift by 32 at:
index = hash >> (32 - dip->i_depth);
As calculated in an open-coded way in dir_make_exhash(), the minimum
depth for an exhash directory is ilog2(sdp->sd_hash_ptrs) and 0 is
invalid as sdp->sd_hash_ptrs is fixed as sdp->bsize / 16 at mount time.
So we can avoid the undefined behaviour by checking for depth values
lower than the minimum in gfs2_dinode_in(). Values greater than the
maximum are already being checked for there.
Also switch the calculation in dir_make_exhash() to use ilog2() to
clarify how the depth is calculated.
Tested with the syzkaller repro.c and xfstests '-g quick'.
Reported-by: syzbot+4708579bb230a0582a57@syzkaller.appspotmail.com
Signed-off-by: Andrew Price <anprice@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'lib/crypto/mpi/mpiutil.c')
0 files changed, 0 insertions, 0 deletions