diff options
| author | Tom Rix <trix@redhat.com> | 2021-05-21 21:48:05 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-07-23 09:04:02 +0200 |
| commit | 280355522d61d106e52cf0536dcf2807a15aec37 (patch) | |
| tree | d02911d2a271d47304fd08252e518d583fee717f /lib/mpi/mpi-sub-ui.c | |
| parent | 6bdad3bb7eb1d91e10998eb21b6f9159064b53af (diff) | |
media: atomisp: improve error handling in gc2235_detect()
Static analysis reports this representative problem
atomisp-gc2235.c:867:20: warning: The right operand
of '|' is a garbage value
id = ((high << 8) | low);
^ ~~~
When gc2235_read_reg() fails, its return val is never written.
For gc2235_detect(), high and low are or-ed and compared
with GC2235_ID, 0x2235. Initialize both to 0 and skip
checking the read returns, it's errors are not passed up, only
-ENODEV is.
Link: https://lore.kernel.org/linux-media/20210521194805.2078135-1-trix@redhat.com
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'lib/mpi/mpi-sub-ui.c')
0 files changed, 0 insertions, 0 deletions
