summaryrefslogtreecommitdiff
path: root/rust/helpers/completion.c
diff options
context:
space:
mode:
authorAbinash Singh <abinashsinghlalotra@gmail.com>2025-08-26 00:09:38 +0530
committerMartin K. Petersen <martin.petersen@oracle.com>2025-08-30 21:18:27 -0400
commitb5f717b31b5e478398740db8aee2ecbc4dd72bf3 (patch)
tree1c977296ef0fc3990d9477db3c67fe40595ca4fb /rust/helpers/completion.c
parent6d55af0f0740bf3d77943425fdafb77dc0fa6bb9 (diff)
scsi: sd: Fix build warning in sd_revalidate_disk()
A build warning was triggered due to excessive stack usage in sd_revalidate_disk(): drivers/scsi/sd.c: In function ‘sd_revalidate_disk.isra’: drivers/scsi/sd.c:3824:1: warning: the frame size of 1160 bytes is larger than 1024 bytes [-Wframe-larger-than=] This is caused by a large local struct queue_limits (~400B) allocated on the stack. Replacing it with a heap allocation using kmalloc() significantly reduces frame usage. Kernel stack is limited (~8 KB), and allocating large structs on the stack is discouraged. As the function already performs heap allocations (e.g. for buffer), this change fits well. Fixes: 804e498e0496 ("sd: convert to the atomic queue limits API") Cc: stable@vger.kernel.org Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Abinash Singh <abinashsinghlalotra@gmail.com> Link: https://lore.kernel.org/r/20250825183940.13211-2-abinashsinghlalotra@gmail.com Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'rust/helpers/completion.c')
0 files changed, 0 insertions, 0 deletions