diff options
author | Chen Yufeng <chenyufeng@iie.ac.cn> | 2025-09-11 23:08:20 +0800 |
---|---|---|
committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2025-09-19 18:59:15 +0200 |
commit | 6b696808472197b77b888f50bc789a3bae077743 (patch) | |
tree | 8828245f6199c78b12a5e8413d1fdc9a28abf3e1 /rust/helpers/mm.c | |
parent | cbf658dd09419f1ef9de11b9604e950bdd5c170b (diff) |
can: hi311x: fix null pointer dereference when resuming from sleep before interface was enabled
This issue is similar to the vulnerability in the `mcp251x` driver,
which was fixed in commit 03c427147b2d ("can: mcp251x: fix resume from
sleep before interface was brought up").
In the `hi311x` driver, when the device resumes from sleep, the driver
schedules `priv->restart_work`. However, if the network interface was
not previously enabled, the `priv->wq` (workqueue) is not allocated and
initialized, leading to a null pointer dereference.
To fix this, we move the allocation and initialization of the workqueue
from the `hi3110_open` function to the `hi3110_can_probe` function.
This ensures that the workqueue is properly initialized before it is
used during device resume. And added logic to destroy the workqueue
in the error handling paths of `hi3110_can_probe` and in the
`hi3110_can_remove` function to prevent resource leaks.
Signed-off-by: Chen Yufeng <chenyufeng@iie.ac.cn>
Link: https://patch.msgid.link/20250911150820.250-1-chenyufeng@iie.ac.cn
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'rust/helpers/mm.c')
0 files changed, 0 insertions, 0 deletions