diff options
| author | Qingfang Deng <dqfext@gmail.com> | 2025-08-14 09:25:58 +0800 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2025-08-19 11:25:32 +0200 |
| commit | 0417adf367a0af11adf7ace849af4638cfb573f7 (patch) | |
| tree | ffc291a113ab881f4925bfb8bacf669f3b96b1a8 /rust/helpers/platform.c | |
| parent | 62c30c544359aa18b8fb2734166467a07d435c2d (diff) | |
ppp: fix race conditions in ppp_fill_forward_path
ppp_fill_forward_path() has two race conditions:
1. The ppp->channels list can change between list_empty() and
list_first_entry(), as ppp_lock() is not held. If the only channel
is deleted in ppp_disconnect_channel(), list_first_entry() may
access an empty head or a freed entry, and trigger a panic.
2. pch->chan can be NULL. When ppp_unregister_channel() is called,
pch->chan is set to NULL before pch is removed from ppp->channels.
Fix these by using a lockless RCU approach:
- Use list_first_or_null_rcu() to safely test and access the first list
entry.
- Convert list modifications on ppp->channels to their RCU variants and
add synchronize_net() after removal.
- Check for a NULL pch->chan before dereferencing it.
Fixes: f6efc675c9dd ("net: ppp: resolve forwarding path for bridge pppoe devices")
Signed-off-by: Qingfang Deng <dqfext@gmail.com>
Link: https://patch.msgid.link/20250814012559.3705-2-dqfext@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'rust/helpers/platform.c')
0 files changed, 0 insertions, 0 deletions
