diff options
author | Jakub Kicinski <kuba@kernel.org> | 2025-09-29 11:15:29 -0700 |
---|---|---|
committer | Paolo Abeni <pabeni@redhat.com> | 2025-09-30 16:32:24 +0200 |
commit | 6f5dacf88a32b3fd8b52c8ea781bf188c42aaa95 (patch) | |
tree | a6930bb8d374204550c90dac51fcb0fb3edc5745 /rust/helpers | |
parent | c18b0f5af42f8f98d4d629e578608188c0ce4652 (diff) |
Revert "net/mlx5e: Update and set Xon/Xoff upon MTU set"
This reverts commit ceddedc969f0532b7c62ca971ee50d519d2bc0cb.
Commit in question breaks the mapping of PGs to pools for some SKUs.
Specifically multi-host NICs seem to be shipped with a custom buffer
configuration which maps the lossy PG to pool 4. But the bad commit
overrides this with pool 0 which does not have sufficient buffer space
reserved. Resulting in ~40% packet loss. The commit also breaks BMC /
OOB connection completely (100% packet loss).
Revert, similarly to commit 3fbfe251cc9f ("Revert "net/mlx5e: Update and
set Xon/Xoff upon port speed set""). The breakage is exactly the same,
the only difference is that quoted commit would break the NIC immediately
on boot, and the currently reverted commit only when MTU is changed.
Note: "good" kernels do not restore the configuration, so downgrade isn't
enough to recover machines. A NIC power cycle seems to be necessary to
return to a healthy state (or overriding the relevant registers using
a custom patch).
Fixes: ceddedc969f0 ("net/mlx5e: Update and set Xon/Xoff upon MTU set")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20250929181529.1848157-1-kuba@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'rust/helpers')
0 files changed, 0 insertions, 0 deletions