diff options
author | Nicolas Frattaroli <nicolas.frattaroli@collabora.com> | 2025-08-25 10:28:30 +0200 |
---|---|---|
committer | Yury Norov <yury.norov@gmail.com> | 2025-09-02 20:06:47 -0400 |
commit | ad24f6e10a5f518acf45a12dce502f090a8858ed (patch) | |
tree | fe0c6c61d7a9d5e966a15701cedc673ab4dfbfd8 /rust/helpers | |
parent | d6de45fd7f1c8ef9f03fd16a97959e42271c3f78 (diff) |
drm/rockchip: dw_hdmi_qp: switch to FIELD_PREP_WM16 macro
The era of hand-rolled HIWORD_UPDATE macros is over, at least for those
drivers that use constant masks.
Replace this driver's HIWORD_UPDATE with the FIELD_PREP_WM16 macro from
hw_bitfield.h. While at it, disambiguate the GRF write to SOC_CON7 by
splitting the definition into the individual bitflags. This is done
because FIELD_PREP_WM16 shifts the value for us according to the mask,
so writing the mask to itself to enable two bits is no longer something
that can be done. It should also not be done anyway because it hides the
true meaning of those two individual bit flags.
HDMI output with this patch has been tested on both RK3588 and RK3576.
On the former, with both present HDMI connectors.
Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Tested-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
Diffstat (limited to 'rust/helpers')
0 files changed, 0 insertions, 0 deletions