diff options
author | Jinliang Zheng <alexjlzheng@tencent.com> | 2025-07-11 16:12:07 +0800 |
---|---|---|
committer | Christian Brauner <brauner@kernel.org> | 2025-07-11 11:42:44 +0200 |
commit | 177bb4cba97aae951b910d8ca248480715d09009 (patch) | |
tree | a176f43b58c601fb08a1795a86ee97e6d9814d5b /scripts/lib/kdoc/kdoc_files.py | |
parent | 0a9e7405131380b57e155f10242b2e25d2e51852 (diff) |
iomap: avoid unnecessary ifs_set_range_uptodate() with locks
In the buffer write path, iomap_set_range_uptodate() is called every
time iomap_end_write() is called. But if folio_test_uptodate() holds, we
know that all blocks in this folio are already in the uptodate state, so
there is no need to go deep into the critical section of state_lock to
execute bitmap_set().
This is because the folios always creep towards ifs_is_fully_uptodate()
state and once they've gotten there folio_mark_uptodate() is called, which
means the folio is uptodate.
Then once a folio is uptodate, there is no route back to !uptodate without
going through the removal of the folio from the page cache. Therefore, it's
fine to use folio_test_uptodate() to short-circuit unnecessary code paths.
Although state_lock may not have significant lock contention due to
folio lock, this patch at least reduces the number of instructions,
especially the expensive lock-prefixed instructions.
Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>
Link: https://lore.kernel.org/20250711081207.1782667-1-alexjlzheng@tencent.com
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'scripts/lib/kdoc/kdoc_files.py')
0 files changed, 0 insertions, 0 deletions