summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLiu Bo <bo.liu@linux.alibaba.com>2018-07-06 03:07:13 +0800
committerJens Axboe <axboe@kernel.dk>2018-07-09 09:07:54 -0600
commit00a8cdb84fcb64c7f9f1061298ff676a96dfaf41 (patch)
treebad084e237984c1e5bfd101e3cbd803740af6159
parentca47e8c72ae141587cabf3dab693f6754d8c416b (diff)
null_blk: remove NULLB_DEV_FL_CONFIGURED on turning off nullb device
Currently mbps knob could only be set once before switching power knob to on, after power knob has been set at least once, there is no way to set mbps knob again due to -EBUSY. As nullb is mainly used for testing, in order to make it flexible, this removes the flag NULLB_DEV_FL_CONFIGURED so that mbps knob can be reset when power knob is off, e.g. echo 0 > /config/nullb/a/power echo 40 > /config/nullb/a/mbps echo 1 > /config/nullb/a/power So does other knobs under /config/nullb/a. Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--drivers/block/null_blk.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c
index 042c778e5a4e..8abfb1059909 100644
--- a/drivers/block/null_blk.c
+++ b/drivers/block/null_blk.c
@@ -390,6 +390,7 @@ static ssize_t nullb_device_power_store(struct config_item *item,
null_del_dev(dev->nullb);
mutex_unlock(&lock);
clear_bit(NULLB_DEV_FL_UP, &dev->flags);
+ clear_bit(NULLB_DEV_FL_CONFIGURED, &dev->flags);
}
return count;