diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-03-14 10:51:50 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-03-16 11:20:04 +0900 |
| commit | 2bbe97830ae623a519291eece719ee74108571ff (patch) | |
| tree | bbaaef47ec3d0d2e45cc44bdbebae3dec8fd4ac3 | |
| parent | f07d4b4270670b099a7034936e519d2efecf81ec (diff) | |
staging/atomisp: silence uninitialized variable warnings
These print an uninitialized value for "opt". Let's just remove the
printk.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c index 327a5c535fab..7f7c6d5133d2 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c @@ -128,11 +128,9 @@ static ssize_t iunit_dbgfun_store(struct device_driver *drv, const char *buf, unsigned int opt; int ret; - if (kstrtouint(buf, 10, &opt)) { - dev_err(atomisp_dev, "%s setting %d value invalid\n", - __func__, opt); - return -EINVAL; - } + ret = kstrtouint(buf, 10, &opt); + if (ret) + return ret; ret = atomisp_set_css_dbgfunc(iunit_debug.isp, opt); if (ret) @@ -154,11 +152,9 @@ static ssize_t iunit_dbgopt_store(struct device_driver *drv, const char *buf, unsigned int opt; int ret; - if (kstrtouint(buf, 10, &opt)) { - dev_err(atomisp_dev, "%s setting %d value invalid\n", - __func__, opt); - return -EINVAL; - } + ret = kstrtouint(buf, 10, &opt); + if (ret) + return ret; iunit_debug.dbgopt = opt; ret = iunit_dump_dbgopt(iunit_debug.isp, iunit_debug.dbgopt); |