diff options
| author | Stefano Garzarella <sgarzare@redhat.com> | 2025-02-13 17:18:25 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2025-02-14 12:58:02 +0100 |
| commit | 362ff1e7c6c20f8d6ebe20682870d471373c608b (patch) | |
| tree | 6d8f3c6f68aa5ea838107bd4c7837e28c2be73b5 | |
| parent | 822b7ec657e99b44b874e052d8540d8b54fe8569 (diff) | |
virtio_snd.h: clarify that `controls` depends on VIRTIO_SND_F_CTLS
As defined in the specification, the `controls` field in the configuration
space is only valid/present if VIRTIO_SND_F_CTLS is negotiated.
From https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html:
5.14.4 Device Configuration Layout
...
controls
(driver-read-only) indicates a total number of all available control
elements if VIRTIO_SND_F_CTLS has been negotiated.
Let's use the same style used in virtio_blk.h to clarify this and to avoid
confusion as happened in QEMU (see link).
Link: https://gitlab.com/qemu-project/qemu/-/issues/2805
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Eugenio Pérez <eperezma@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250213161825.139952-1-sgarzare@redhat.com
| -rw-r--r-- | include/uapi/linux/virtio_snd.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/uapi/linux/virtio_snd.h b/include/uapi/linux/virtio_snd.h index 5f4100c2cf04..a4cfb9f6561a 100644 --- a/include/uapi/linux/virtio_snd.h +++ b/include/uapi/linux/virtio_snd.h @@ -25,7 +25,7 @@ struct virtio_snd_config { __le32 streams; /* # of available channel maps */ __le32 chmaps; - /* # of available control elements */ + /* # of available control elements (if VIRTIO_SND_F_CTLS) */ __le32 controls; }; |