diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-05-25 15:54:11 +0400 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2022-06-27 09:58:41 +0200 |
| commit | 3a149169e4a2f9127022fec6ef5d71b4e804b3b9 (patch) | |
| tree | 1bb107f9835d20020828fb6194ad40b6dc369921 | |
| parent | e5d6eeead88e40282cb6dff38f8effd6341561b1 (diff) | |
drm/mcde: Fix refcount leak in mcde_dsi_bind
Every iteration of for_each_available_child_of_node() decrements
the reference counter of the previous node. There is no decrement
when break out from the loop and results in refcount leak.
Add missing of_node_put() to fix this.
Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220525115411.65455-1-linmq006@gmail.com
| -rw-r--r-- | drivers/gpu/drm/mcde/mcde_dsi.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c index 5651734ce977..9f9ac8699310 100644 --- a/drivers/gpu/drm/mcde/mcde_dsi.c +++ b/drivers/gpu/drm/mcde/mcde_dsi.c @@ -1111,6 +1111,7 @@ static int mcde_dsi_bind(struct device *dev, struct device *master, bridge = of_drm_find_bridge(child); if (!bridge) { dev_err(dev, "failed to find bridge\n"); + of_node_put(child); return -EINVAL; } } |