diff options
| author | Rosen Penev <rosenp@gmail.com> | 2024-10-30 13:37:23 -0700 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-11-03 14:37:43 -0800 |
| commit | 3fb5272de0347da9cc7f8ed8b38e253ca06d664e (patch) | |
| tree | e56696781f18dcd35b12cb2414f08a1dc49b9d5e | |
| parent | e2da0216e55ee25f8f4a582b6ef6a3a4e7867963 (diff) | |
net: ibm: emac: zmii: use devm for mutex_init
It seems that since inception, this driver never called mutex_destroy in
_remove. Use devm to handle this automatically.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://patch.msgid.link/20241030203727.6039-9-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/ethernet/ibm/emac/zmii.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/net/ethernet/ibm/emac/zmii.c b/drivers/net/ethernet/ibm/emac/zmii.c index e9097b9ceb3d..cb57c960b34d 100644 --- a/drivers/net/ethernet/ibm/emac/zmii.c +++ b/drivers/net/ethernet/ibm/emac/zmii.c @@ -235,13 +235,17 @@ static int zmii_probe(struct platform_device *ofdev) struct device_node *np = ofdev->dev.of_node; struct zmii_instance *dev; struct resource regs; + int err; dev = devm_kzalloc(&ofdev->dev, sizeof(struct zmii_instance), GFP_KERNEL); if (!dev) return -ENOMEM; - mutex_init(&dev->lock); + err = devm_mutex_init(&ofdev->dev, &dev->lock); + if (err) + return err; + dev->ofdev = ofdev; dev->mode = PHY_INTERFACE_MODE_NA; |