diff options
| author | Matthew Wilcox (Oracle) <willy@infradead.org> | 2023-08-21 14:44:28 +0100 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2023-09-15 10:33:29 +0200 |
| commit | 4de7b17fd05d03fa919e8c47fc66122bd24d7b6c (patch) | |
| tree | bc97f8b4e62134399d59729f17517b6dded55422 | |
| parent | 0e34600ac9317dbe5f0a7bfaa3d7187d757572ed (diff) | |
sched: Assert for_each_thread() is properly locked
list_for_each_entry_rcu() takes an optional fourth argument which
allows RCU to assert that the correct lock is held. Several callers
of for_each_thread() rely on their caller to be holding the appropriate
lock, so this is a useful assertion to include.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Link: https://lore.kernel.org/r/20230821134428.2504912-1-willy@infradead.org
| -rw-r--r-- | include/linux/sched/signal.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/sched/signal.h b/include/linux/sched/signal.h index 0014d3adaf84..9610bad018a3 100644 --- a/include/linux/sched/signal.h +++ b/include/linux/sched/signal.h @@ -656,7 +656,8 @@ extern bool current_is_single_threaded(void); while ((t = next_thread(t)) != g) #define __for_each_thread(signal, t) \ - list_for_each_entry_rcu(t, &(signal)->thread_head, thread_node) + list_for_each_entry_rcu(t, &(signal)->thread_head, thread_node, \ + lockdep_is_held(&tasklist_lock)) #define for_each_thread(p, t) \ __for_each_thread((p)->signal, t) |