diff options
| author | Pei Xiao <xiaopei01@kylinos.cn> | 2025-12-05 10:02:41 +0800 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2025-12-07 14:10:18 -0800 |
| commit | 541dfb49dcb80c2509e030842de77adfb77820f5 (patch) | |
| tree | 154efa6b462ce733d223a7646bcc3eeca262f35c | |
| parent | fae00a7186cecf90a57757a63b97a0cbcf384fe9 (diff) | |
hwmon: (emc2305) fix double put in emc2305_probe_childs_from_dt
./drivers/hwmon/emc2305.c:597:4-15: ERROR: probable double put
Device node iterators put the previous value of the index variable, so an
explicit put causes a double put.
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Link: https://lore.kernel.org/r/tencent_CD373F952BE48697C949E39CB5EB77841D06@qq.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/emc2305.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/hwmon/emc2305.c b/drivers/hwmon/emc2305.c index 60809289f816..b0f2318c97e3 100644 --- a/drivers/hwmon/emc2305.c +++ b/drivers/hwmon/emc2305.c @@ -593,10 +593,8 @@ static int emc2305_probe_childs_from_dt(struct device *dev) for_each_child_of_node(dev->of_node, child) { if (of_property_present(child, "reg")) { ret = emc2305_of_parse_pwm_child(dev, child, data); - if (ret) { - of_node_put(child); + if (ret) continue; - } count++; } } |