diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2022-06-30 09:41:53 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-06-30 21:07:03 -0700 |
| commit | 5a24389457ba82e8ce176e0325f5a1b79ed5be14 (patch) | |
| tree | fa1f02572cfe9bad9939a526ced47eda3c8ae033 | |
| parent | 34eff17ec4e2b449f92705ce4d6f592fc1a05926 (diff) | |
net: dsa: rzn1-a5psw: add missing of_node_put() in a5psw_pcs_get()
of_parse_phandle() will increase the refcount of 'pcs_node', so add
of_node_put() before return from a5psw_pcs_get().
Fixes: 888cdb892b61 ("net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220630014153.1888811-1-yangyingliang@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/dsa/rzn1_a5psw.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c index 5b14e2ba9b79..0744e8162e1d 100644 --- a/drivers/net/dsa/rzn1_a5psw.c +++ b/drivers/net/dsa/rzn1_a5psw.c @@ -917,12 +917,14 @@ static int a5psw_pcs_get(struct a5psw *a5psw) } a5psw->pcs[reg] = pcs; + of_node_put(pcs_node); } of_node_put(ports); return 0; free_pcs: + of_node_put(pcs_node); of_node_put(port); of_node_put(ports); a5psw_pcs_free(a5psw); |