diff options
| author | Daniel Hsu <d486250@gmail.com> | 2025-03-25 16:10:08 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2025-03-26 13:03:59 +0000 |
| commit | 70facbf978ac90c6da17a3de2a8dd111b06f1bac (patch) | |
| tree | f1e3ddb8fa713e9a297b33ae9981cae83d94d1f8 | |
| parent | c7d82913d5f9e97860772ee4051eaa66b56a6273 (diff) | |
mctp: Fix incorrect tx flow invalidation condition in mctp-i2c
Previously, the condition for invalidating the tx flow in
mctp_i2c_invalidate_tx_flow() checked if `rc` was nonzero.
However, this could incorrectly trigger the invalidation
even when `rc > 0` was returned as a success status.
This patch updates the condition to explicitly check for `rc < 0`,
ensuring that only error cases trigger the invalidation.
Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>
Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/mctp/mctp-i2c.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/mctp/mctp-i2c.c b/drivers/net/mctp/mctp-i2c.c index d74d47dd6e04..f782d93f826e 100644 --- a/drivers/net/mctp/mctp-i2c.c +++ b/drivers/net/mctp/mctp-i2c.c @@ -537,7 +537,7 @@ static void mctp_i2c_xmit(struct mctp_i2c_dev *midev, struct sk_buff *skb) rc = __i2c_transfer(midev->adapter, &msg, 1); /* on tx errors, the flow can no longer be considered valid */ - if (rc) + if (rc < 0) mctp_i2c_invalidate_tx_flow(midev, skb); break; |