summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2020-10-19 12:06:42 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-10-28 12:31:39 +0100
commit726c8277bc5e67799f2ac3ca7fc795d4bf07264f (patch)
tree6e16864c8a2fdac27774092ab2b0b231a5e4a196
parent862ee699fefe1e6d6f2c1518395f0b999b8beb15 (diff)
usb: atm: Replace in_interrupt() usage in comment
in_interrupt() is a pretty vague context description as it means: hard interrupt, soft interrupt or bottom half disabled regions. Replace the vague comment with a proper reasoning why spin_lock_irqsave() needs to be used. Signed-off-by: Ahmed S. Darwish <a.darwish@linutronix.de> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Duncan Sands <duncan.sands@free.fr> Cc: linux-usb@vger.kernel.org Link: https://lore.kernel.org/r/20201019101110.944939915@linutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/atm/usbatm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c
index 56fe30d247da..f49792f951ab 100644
--- a/drivers/usb/atm/usbatm.c
+++ b/drivers/usb/atm/usbatm.c
@@ -249,7 +249,7 @@ static void usbatm_complete(struct urb *urb)
/* vdbg("%s: urb 0x%p, status %d, actual_length %d",
__func__, urb, status, urb->actual_length); */
- /* usually in_interrupt(), but not always */
+ /* Can be invoked from task context, protect against interrupts */
spin_lock_irqsave(&channel->lock, flags);
/* must add to the back when receiving; doesn't matter when sending */