diff options
| author | Rob Herring <robh@kernel.org> | 2023-03-10 08:47:23 -0600 |
|---|---|---|
| committer | Rob Herring <robh@kernel.org> | 2023-04-21 09:20:56 -0500 |
| commit | 83f32497890c8f3e5d2337bc4f353442641b6750 (patch) | |
| tree | 14f69ccd80e3bec4c36b3f0506d9f2a430b89376 | |
| parent | c763a0833fd451a7bbe207be843caf1666f46612 (diff) | |
soc: fsl: Use of_property_present() for testing DT property presence
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.
Link: https://lore.kernel.org/r/20230310144723.1545069-1-robh@kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
| -rw-r--r-- | drivers/soc/fsl/qbman/dpaa_sys.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/soc/fsl/qbman/dpaa_sys.c b/drivers/soc/fsl/qbman/dpaa_sys.c index 9dd8bb571dbc..33751450047e 100644 --- a/drivers/soc/fsl/qbman/dpaa_sys.c +++ b/drivers/soc/fsl/qbman/dpaa_sys.c @@ -39,8 +39,7 @@ int qbman_init_private_mem(struct device *dev, int idx, dma_addr_t *addr, { struct device_node *mem_node; struct reserved_mem *rmem; - struct property *prop; - int len, err; + int err; __be32 *res_array; mem_node = of_parse_phandle(dev->of_node, "memory-region", idx); @@ -63,8 +62,9 @@ int qbman_init_private_mem(struct device *dev, int idx, dma_addr_t *addr, * This is needed because QBMan HW does not allow the base address/ * size to be modified once set. */ - prop = of_find_property(mem_node, "reg", &len); - if (!prop) { + if (!of_property_present(mem_node, "reg")) { + struct property *prop; + prop = devm_kzalloc(dev, sizeof(*prop), GFP_KERNEL); if (!prop) return -ENOMEM; |