summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJiri Pirko <jiri@mellanox.com>2017-12-28 16:52:10 +0100
committerDavid S. Miller <davem@davemloft.net>2017-12-28 12:18:31 -0500
commit8ec69574031bb8e0a19cf318c093acc871abd965 (patch)
treecbd5e0fed8edceadb604e3caf29f0be5ab58d08b
parentd3dbd7a6aadfa089eeb99318ba604638c2ab035c (diff)
net: sched: don't set extack message in case the qdisc will be created
If the qdisc is not found here, it is going to be created. Therefore, this is not an error path. Remove the extack message set and don't confuse user with error message in case the qdisc was created successfully. Fixes: 09215598119e ("net: sched: sch_api: handle generic qdisc errors") Signed-off-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/sched/sch_api.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 3a3a1da6b071..81ecf5bec26d 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -1402,10 +1402,8 @@ replay:
return -EINVAL;
}
q = qdisc_lookup(dev, tcm->tcm_handle);
- if (!q) {
- NL_SET_ERR_MSG(extack, "No qdisc found for specified handle");
+ if (!q)
goto create_n_graft;
- }
if (n->nlmsg_flags & NLM_F_EXCL) {
NL_SET_ERR_MSG(extack, "Exclusivity flag on, cannot override");
return -EEXIST;