summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZihao Tang <tangzihao1@hisilicon.com>2021-03-16 17:41:06 +0800
committerDavid S. Miller <davem@davemloft.net>2021-03-16 15:23:20 -0700
commit91306d1d131ee20afe6447668ba3a8f13151b9f4 (patch)
tree0bc82b7537e42bfa1aa408facb5bdc5a859ee1c1
parent51481c51d3327fa7ef82c610142193313f204529 (diff)
net: ipa: Remove useless error message
Fix the following coccicheck report: drivers/net/ipa/gsi.c:1341:2-9: line 1341 is redundant because platform_get_irq() already prints an error Remove dev_err() messages after platform_get_irq_byname() failures. Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com> Signed-off-by: Jay Fang <f.fangjian@huawei.com> Reviewed-by: Alex Elder <elder@linaro.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ipa/gsi.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
index 390d3403386a..2119367b93ea 100644
--- a/drivers/net/ipa/gsi.c
+++ b/drivers/net/ipa/gsi.c
@@ -1337,10 +1337,9 @@ static int gsi_irq_init(struct gsi *gsi, struct platform_device *pdev)
int ret;
ret = platform_get_irq_byname(pdev, "gsi");
- if (ret <= 0) {
- dev_err(dev, "DT error %d getting \"gsi\" IRQ property\n", ret);
+ if (ret <= 0)
return ret ? : -EINVAL;
- }
+
irq = ret;
ret = request_irq(irq, gsi_isr, 0, "gsi", gsi);