summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordyoung@redhat.com <dyoung@redhat.com>2013-05-16 14:31:30 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-05-21 09:05:52 -0700
commit97521978c5ea80857d4f4f74d4e1fc93721482cf (patch)
tree7382ef10ce4cae297584ce0c08859da487d0994e
parent1c04fc3536b9e6d143991a8c5c16b04866baeed6 (diff)
driver core: print sysfs attribute name when warning about bogus permissions
Make it obvious to see what attribute is using bogus permissions. Signed-off-by: Dave Young <dyoung@redhat.com> Acked-by: Felipe Balbi <balbi@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/base/core.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 016312437577..2499cefdcdf2 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -572,9 +572,11 @@ int device_create_file(struct device *dev,
if (dev) {
WARN(((attr->attr.mode & S_IWUGO) && !attr->store),
- "Write permission without 'store'\n");
+ "Attribute %s: write permission without 'store'\n",
+ attr->attr.name);
WARN(((attr->attr.mode & S_IRUGO) && !attr->show),
- "Read permission without 'show'\n");
+ "Attribute %s: read permission without 'show'\n",
+ attr->attr.name);
error = sysfs_create_file(&dev->kobj, &attr->attr);
}