diff options
| author | Anant Thazhemadam <anant.thazhemadam@gmail.com> | 2020-08-26 13:09:15 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-09-03 11:05:55 +0200 |
| commit | a4f3761771bc45ab433bd38fd437bb2e40617f27 (patch) | |
| tree | a3d42120f76640bdeddf1e205bbb4db87f206c30 | |
| parent | 0104949370228417fd417bd42fb3d99a59ff6ed6 (diff) | |
media: atomisp: fix "dubious: !x | !y" sparse warning
Upon running Sparse, "warning: dubious: !x | !y" is brought to notice
for this file. Logical and bitwise OR are basically the same in this
context, so it doesn't cause a runtime bug. But let's change it to
logical OR to make it a little bit cleaner and silence the Sparse
warning.
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
| -rw-r--r-- | drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c index 358cb7d2cd4c..3b850bb2d39d 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c @@ -58,7 +58,7 @@ sh_css_vf_downscale_log2( unsigned int ds_log2 = 0; unsigned int out_width; - if ((!out_info) | (!vf_info)) + if ((!out_info) || (!vf_info)) return -EINVAL; out_width = out_info->res.width; |