diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-04-30 11:03:46 +0300 |
|---|---|---|
| committer | Javier Martinez Canillas <javierm@redhat.com> | 2025-04-30 14:51:40 +0200 |
| commit | b389df0f6b5a2e0655e9f101af97d75e35fb874c (patch) | |
| tree | 405f602c670e49b04881f0e927403bc7c98eaa4d | |
| parent | 0d607a59a0f6593e72630854a8bcb8b01b8dce40 (diff) | |
drm/st7571-i2c: Fix IS_ERR() vs NULL checks in probe()
The devm_kzalloc() function returns NULL on failure, not error pointers.
Also printing an error message for kmalloc() failures is against kernel
style so just return -ENOMEM without printing a message. (Kmalloc
already prints a message).
Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://lore.kernel.org/r/aBHZYgPPPYY-J8Vd@stanley.mountain
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/tiny/st7571-i2c.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/gpu/drm/tiny/st7571-i2c.c b/drivers/gpu/drm/tiny/st7571-i2c.c index dc410ec41baf..eec846892962 100644 --- a/drivers/gpu/drm/tiny/st7571-i2c.c +++ b/drivers/gpu/drm/tiny/st7571-i2c.c @@ -908,16 +908,14 @@ static int st7571_probe(struct i2c_client *client) st7571->hwbuf = devm_kzalloc(&client->dev, (st7571->nlines * st7571->ncols * st7571->bpp) / 8, GFP_KERNEL); - if (IS_ERR(st7571->hwbuf)) - return dev_err_probe(&client->dev, PTR_ERR(st7571->hwbuf), - "Failed to allocate intermediate buffer\n"); + if (!st7571->hwbuf) + return -ENOMEM; st7571->row = devm_kzalloc(&client->dev, (st7571->ncols * st7571->bpp), GFP_KERNEL); - if (IS_ERR(st7571->row)) - return dev_err_probe(&client->dev, PTR_ERR(st7571->row), - "Failed to allocate row buffer\n"); + if (!st7571->row) + return -ENOMEM; ret = st7571_mode_config_init(st7571); if (ret) |