diff options
| author | Ian Rogers <irogers@google.com> | 2025-02-28 14:22:58 -0800 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2025-03-11 18:55:37 -0700 |
| commit | bda840191d2aae3b7cadc3ac21835dcf29487191 (patch) | |
| tree | ecb6be338773d03c173bdcfe2d3a690e4adff6f0 | |
| parent | b10f74308e1305275e69ddde711ec817cc69e306 (diff) | |
perf debug: Avoid stack overflow in recursive error message
In debug_file, pr_warning_once is called on error. As that function
calls debug_file the function will yield a stack overflow. Switch the
location of the call so the recursion is avoided.
Reviewed-by: Howard Chu <howardchu95@gmail.com>
Signed-off-by: Ian Rogers <irogers@google.com>
Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Link: https://lore.kernel.org/r/20250228222308.626803-2-irogers@google.com
Fixes: ec49230cf6dda704 ("perf debug: Expose debug file")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
| -rw-r--r-- | tools/perf/util/debug.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/util/debug.c b/tools/perf/util/debug.c index 995f6bb05b5f..f9ef7d045c92 100644 --- a/tools/perf/util/debug.c +++ b/tools/perf/util/debug.c @@ -46,8 +46,8 @@ int debug_type_profile; FILE *debug_file(void) { if (!_debug_file) { - pr_warning_once("debug_file not set"); debug_set_file(stderr); + pr_warning_once("debug_file not set"); } return _debug_file; } |